Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow Drupal to wrap the Symfony test listener (5.1 backport)#38031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexpott
Copy link
Contributor

QA
Branch?5.1
Bug fix?kinda
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This is a backport of#37708

@alexpottalexpott changed the titleAllow Drupal to wrap the Symfony test listenerAllow Drupal to wrap the Symfony test listener (5.1 backport)Sep 2, 2020
@nicolas-grekasnicolas-grekas added this to the5.1 milestoneSep 2, 2020
$parsedMsg =unserialize($this->message);
restore_error_handler();
set_error_handler(function () {});
$parsedMsg = @unserialize($this->message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the `@ is not required anymore since the error handler ignores everything

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's in master - that's why I added it back.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll remove it here and submit a PR to clean up master.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Created#38033 to address this in master.

@fabpot
Copy link
Member

Thank you@alexpott.

@fabpotfabpot merged commita36c43b intosymfony:5.1Sep 2, 2020
@fabpotfabpot mentioned this pull requestSep 27, 2020
nicolas-grekas added a commit that referenced this pull requestOct 2, 2020
…e TestsListener (fancyweb)This PR was merged into the 5.1 branch.Discussion----------[PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -#38031 caused an unwanted regression: if the frame `class` matches `SymfonyTestsListenerFor` it used to always return, now it continues so the `originClass` and `originMethod` properties are set. Therefore, the deprecation is considered as coming from the test listener. It ends up in the "legacy" group and muted because the test listeners contains the word "Legacy" in their namespaces.Example test:```php<?phpnamespace App\Tests;use PHPUnit\Framework\TestCase;use Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher;final class FooTest extends TestCase{    public function test(): void    {        // ExtractingEventDispatcher is@internal        new class extends ExtractingEventDispatcher {};        $this->assertTrue(true);    }}```On 4.4:```Other deprecation notices (1)  1x: The "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher" class is considered internal. It may change without further notice. You should not use it from "Symfony\Component\EventDispatcher\DependencyInjection\ExtractingEventDispatcher@anonymous".```On 5.1:```Legacy deprecation notices (1)```Commits-------1ba06a0 [PhpUnitBridge] Fix Deprecation file when it comes from the TestsListener
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@alexpott@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp