Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnit] Add polyfill for assertMatchesRegularExpression()#37960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dunglas
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

assertRegExp() is now deprecated in favor ofassertMatchesRegularExpression.

@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpotforce-pushed thefeat/assertMatchesRegularExpression-polyfill branch from8cfc0d2 to33eccd2CompareAugust 27, 2020 14:03
@fabpotfabpot merged commit7da56f3 intosymfony:4.4Aug 27, 2020
@dunglasdunglas deleted the feat/assertMatchesRegularExpression-polyfill branchAugust 27, 2020 14:29
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedAug 27, 2020•
edited
Loading

This has been merged already in master in#37567

@nicolas-grekas
Copy link
Member

I'd suggest reverting + using master@dunglas

@fabpot
Copy link
Member

I thought we were merging this kind of features in the lowest branch.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedAug 27, 2020•
edited
Loading

Well, we can :)
The first polyfilling bytes in#32922 were merged as a feature.
We can backport#37567 in 4.4 also.

@dunglas
Copy link
MemberAuthor

This one has been merged in 4.4 so I was confused :)#36408
Ok for me to revert!

fabpot added a commit that referenced this pull requestAug 27, 2020
…olyfillAssertTrait (dunglas)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | n/aMove the polyfill method introduced in#37960 in the `Assert` trait. Sorry I noticed this trait later.Commits-------0426113 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
fabpot added a commit that referenced this pull requestAug 28, 2020
This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] Polyfill new phpunit 9.1 assertions| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#37320| License       | MIT| Doc PR        | -Backport of#37567, follows the discussion on#37960.Commits-------d945b88 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
This was referencedAug 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GromNaNGromNaNGromNaN left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dunglas@fabpot@nicolas-grekas@GromNaN@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp