Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpunitBridge] Fix deprecation type detection (when several autoload files are used)#37959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:4.4froml-vo:fix_type_detection_with_multiple_vendor_dirsSep 2, 2020
Merged
[PhpunitBridge] Fix deprecation type detection (when several autoload files are used)#37959
fabpot merged 1 commit intosymfony:4.4froml-vo:fix_type_detection_with_multiple_vendor_dirsSep 2, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4c739ce to223e847CompareContributorAuthor
l-vo commentedAug 27, 2020
status: needs work |
11ca181 to1fa3818CompareContributorAuthor
l-vo commentedAug 28, 2020
status: needs review |
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
When using several vendor directories
1fa3818 tocc7b6c5Comparenicolas-grekas approved these changesSep 2, 2020
Member
fabpot commentedSep 2, 2020
Thank you@l-vo. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Several autoload files are supported by the PHPUnit Bridge but when the internal paths are registered (for deprecation type detection), the paths (from prefixes) of the last autoload file override the paths previously registered. This PR fixes this bug.