Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] allow null for $message of filter methodtrans#37941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedAug 25, 2020
Closing as explained in the issue. |
Flinsch commentedAug 25, 2020
Have you even read the issue in full,@fabpot? Sorry, I don't mean to be rude, but I can't understand how you can just close this without even considering. |
fabpot commentedAug 26, 2020
Reopening |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me, we did this already in the Translator class.
Please add a test case.
nicolas-grekas commentedAug 26, 2020
Can you please rebase and target 5.1 also? |
Flinsch commentedAug 26, 2020
Will do. Thank you for your consideration. |
trans did not allow null values for $message parameter anymoretranstranstransFlinsch commentedAug 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas, the source branch cannot be changed for a pull request. I can rebase 5.0 onto 5.1 but the source branch will still read 5.0 which might lead to confusions. What should I do in your opinion? Should we stick to the name 5.0 for the source branch or should I replace the pull request with a new one having target/base branch and source branch both set to 5.1? The Symfony guidelines on how to create pull requests say that "bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.)" That's why I have chosen 5.0 in the first place. Just as a remark. I'm sorry if that was wrong. |
nicolas-grekas commentedAug 26, 2020
You can rebase your branch 5.0 on 5.1 yes, that'd be fine on our side. You could then delete it on your fork, 5.0 is not maintained anymore anyway. |
Flinsch commentedAug 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Done. fabbot.io still has comlaints about "Common Typos" and "Merge Commits" which don't seem to have any relations to my changes/commits however. |
fabpot commentedAug 26, 2020
Looks like you forgot to rebase your changes on 5.1 (many unrelated commits). When done, push it again, that should be enough. |
… allow null values for `$message` parameter anymore
nicolas-grekas commentedAug 26, 2020
Thank you@Flinsch. |
Flinsch commentedAug 26, 2020
I can only return my thanks,@nicolas-grekas. |
With Symfony 5.0, filter method
transof Symfony Twig Bridge does not allow null values for$messageparameter anymore, breaking backward compatibility. See also#37931. The included commit provides a fix to this BC break by allowing null values again.