Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] fixed fix encoding of cache keys with anonymous classes#37937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frommichaelzangerle:fix-36589
Aug 31, 2020

Conversation

@michaelzangerle
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36589
LicenseMIT
Doc PR-

@michaelzangerlemichaelzangerle marked this pull request as ready for reviewAugust 25, 2020 11:55
@michaelzangerlemichaelzangerle changed the title[WIP][Serializer] fixed fix encoding of cache keys[Serializer] fixed fix encoding of cache keysAug 25, 2020
@michaelzangerle
Copy link
ContributorAuthor

Adjusted test case in the framework bundle to match new cache key escaping. Tests for serializer and framework bundle run through locally and in AppVeyor but fail on Travis for some reason. One error on travis is probably related to the change but I can't reproduce it locally as it should be fixed with the change. The other is a redis error according to the error message. Any advice?

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneAug 31, 2020
@nicolas-grekasnicolas-grekas changed the title[Serializer] fixed fix encoding of cache keys[Serializer] fixed fix encoding of cache keys with anonymous classesAug 31, 2020
@nicolas-grekas
Copy link
Member

Thank you@michaelzangerle.

@nicolas-grekasnicolas-grekas merged commit93459a9 intosymfony:4.4Aug 31, 2020
This was referencedSep 2, 2020
hultberg pushed a commit to hultberg/symfony that referenced this pull requestSep 17, 2021
…anonymous classes (michaelzangerle)This PR was squashed before being merged into the 4.4 branch.Discussion----------[Serializer] fixed fix encoding of cache keys with anonymous classes| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fixsymfony#36589| License       | MIT| Doc PR        | -Commits-------3a46753 [Serializer] fixed fix encoding of cache keys with anonymous classes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Serializer] Cache error normalizing anonymous class

3 participants

@michaelzangerle@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp