Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] fix chaining promises returned by HttplugClient#37927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesAug 26, 2020
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(I just did some minor tweaks)
fabpot approved these changesAug 26, 2020
Member
fabpot commentedAug 26, 2020
Thank you@CthulhuDen. |
Merged
nicolas-grekas added a commit that referenced this pull requestJan 13, 2022
…\promise_for (plozmun)This PR was merged into the 5.3 branch.Discussion----------[HttpClient] Remove deprecated usage of GuzzleHttp\Promise\promise_for| Q | A| ------------- | ---| Branch? | 5.3,| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Similar to#44890 but this function was introduced in 5.1#37927Commits-------3d2ed70 [HttpClient] Remove deprecated usage of GuzzleHttp\Promise\promise_for
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guzzle runtime does not play too well with foreign promises, which can be fixed by wrapping them with
promise_for.Added failing test case from#37925 and suggested fix.
Should not break BC because
thencallback results get resolved before being passed to nextthencallback or returned fromwait.