Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Fixed mandrill api header structure#37900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dmaicher commentedAug 20, 2020
There is a test failure though: |
wulff commentedAug 20, 2020
I have updated the relevant test case, but now the Travis test fails on an unrelated test:https://travis-ci.org/github/symfony/symfony/jobs/719745366#L7547. |
dmaicher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the other test failures seem unrelated
dmaicher commentedAug 21, 2020
@wulff can you rebase this to 4.4? There the issue also exists, right? |
60c4191 toaeb4c5eComparefabpot commentedAug 21, 2020
Thank you@wulff. |
| } | ||
| $payload['message']['headers'][] =$name.':'.$header->getBodyAsString(); | ||
| $payload['message']['headers'][$name] =$header->getBodyAsString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How does Mandrill handle several headers with the same name? Here you will only ever get the last one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As far as I can tell, Mandrill only allows one of each header in the headers field.
When using the Mandrill API transport, it is not possible to set a reply-to address.
How to reproduce
Create a new email and add a reply-to address:
The expected result is a payload which contains the following headers:
But instead, the
getPayload()method produces these headers:Additional context
Seehttps://mandrillapp.com/api/docs/messages.html.