Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Reorder headers used to determine Sender#37888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cvmiert commentedAug 19, 2020
I noticed the failed Travis build, but the failing tests seem unrelated to the changes in this PR. I'm not sure how I can address that. Can anyone advise please? |
77f595f to6648be4CompareUse the `Return-Path` header as the last candidate to determine theEnvelope's sender address.The `Return-Path` is usually configured _in addition_ to the `Sender`and/or `From` header: it allows for email bounces and complaints to besent to a dedicated email address. It should therefore not be used asthe first candidate header to determine the sender.
6648be4 to7e60a8fComparefabpot commentedAug 19, 2020
Thank you@cvmiert. |
cscrewsandcaptains commentedMar 30, 2022
You wrote in the introductory comment: You are correct that the "return-path" is set in addition to the "sender" and/or "from". And it is used for bounces of emails. You are also right that "return-path" should not be used as the first header candidate to determine the sender. But please don't use "return-path" as the last candidate. The last one must be "from". "from" is alway set and thus is the last candidate. |
Use the
Return-Pathheader as the last candidate to determine the Envelope's sender address.The
Return-Pathis usually configuredin addition to theSenderand/orFromheader: it allows for email bounces and complaints to be sent to a dedicated email address. It should therefor not be used as the first candidate header to determine the sender.