Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Reorder headers used to determine Sender#37888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromcvmiert:mailer/fix-sender-from-headers
Aug 19, 2020

Conversation

@cvmiert
Copy link

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Use theReturn-Path header as the last candidate to determine the Envelope's sender address.

TheReturn-Path is usually configuredin addition to theSender and/orFrom header: it allows for email bounces and complaints to be sent to a dedicated email address. It should therefor not be used as the first candidate header to determine the sender.

dmaicher reacted with thumbs up emojicarusogabriel reacted with rocket emoji
@cvmiertcvmiert marked this pull request as ready for reviewAugust 19, 2020 16:07
@cvmiert
Copy link
Author

I noticed the failed Travis build, but the failing tests seem unrelated to the changes in this PR. I'm not sure how I can address that. Can anyone advise please?

@cvmiertcvmiertforce-pushed themailer/fix-sender-from-headers branch from77f595f to6648be4CompareAugust 19, 2020 17:00
Use the `Return-Path` header as the last candidate to determine theEnvelope's sender address.The `Return-Path` is usually configured _in addition_ to the `Sender`and/or `From` header: it allows for email bounces and complaints to besent to a dedicated email address. It should therefore not be used asthe first candidate header to determine the sender.
@cvmiertcvmiertforce-pushed themailer/fix-sender-from-headers branch from6648be4 to7e60a8fCompareAugust 19, 2020 17:05
@fabpotfabpot changed the base branch frommaster to4.4August 19, 2020 17:15
@fabpot
Copy link
Member

Thank you@cvmiert.

cvmiert and carusogabriel reacted with heart emoji

@fabpotfabpot merged commit3c270fb intosymfony:4.4Aug 19, 2020
@cvmiertcvmiert deleted the mailer/fix-sender-from-headers branchAugust 21, 2020 14:16
This was referencedAug 31, 2020
@xabbuhxabbuh added this to the4.4 milestoneAug 31, 2020
@fabpotfabpot mentioned this pull requestFeb 25, 2022
@cscrewsandcaptains
Copy link

You wrote in the introductory comment:
"The Return-Path is usually configured in addition to the Sender and/or From header: it allows for email bounces and complaints to be sent to a dedicated email address. It should therefor not be used as the first candidate header to determine the sender."

You are correct that the "return-path" is set in addition to the "sender" and/or "from". And it is used for bounces of emails. You are also right that "return-path" should not be used as the first header candidate to determine the sender.

But please don't use "return-path" as the last candidate. The last one must be "from". "from" is alway set and thus is the last candidate.
If you want to use bounces, set the "return-path". And in this case, the sender must be the "return-path" email, not the "from" email. And only if the "sender" header is set, it will override the "return- path".
I am not sure if this is correct for all email daemons, but for sendmail it is necessary.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@cvmiert@fabpot@cscrewsandcaptains@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp