NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[YAML] Unexpected characters using YAML compact syntax#37876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

RevZer0 wants to merge6 commits intosymfony:4.4fromRevZer0:37788

Closed

[YAML] Unexpected characters using YAML compact syntax#37876

RevZer0 wants to merge6 commits intosymfony:4.4fromRevZer0:37788

Conversation

Copy link

RevZer0 commentedAug 18, 2020

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#37788
License	MIT
Doc PR	not available

Issue fix

[YAML] Unexpected characters using YAML compact syntaxsymfony#37788

24fc166

RevZer0 requested a review fromxabbuh as acode owner

August 18, 2020 11:20

carsonbot added Status: Needs Review Yaml Bug labels

Aug 18, 2020

RevZer0 added2 commits

August 18, 2020 14:23

Fix coding standard issues

c899773

Fix Yaml component parser exception messages format

87deb21

fabpot requested changes

Aug 18, 2020

View reviewed changes

src/Symfony/Component/Yaml/Tests/ParserTest.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Yaml/Parser.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 18, 2020

RevZer0 added3 commits

August 18, 2020 14:29

Fix tests after exceptions format update

9708c1a

Rollback exception formatting

2670518

Update tests so HEREDOC syntax became suitable on PHP < 7.3 versions

80445f8

RevZer0 requested a review fromfabpot

August 18, 2020 12:27

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Aug 18, 2020

Copy link

Member

xabbuh commentedAug 18, 2020

I think we should investigate if this overlaps with#33763.

Copy link

Author

RevZer0 commentedAug 18, 2020

I think we should investigate if this overlaps with#33763.

Haven't seen this pr tbh. As far as I see your update will fix this issue

Copy link

Member

fabpot commentedAug 19, 2020

Does it mean that we can close this one in favor of#33763?

Copy link

Author

RevZer0 commentedAug 19, 2020

@fabpot I think yes

fabpot closed this

Aug 19, 2020

Copy link

Member

xabbuh commentedNov 15, 2020

Thank you for working on this@RevZer0. I have added your test cases to#33763.

xabbuh mentioned this pull request

Nov 15, 2020

[Yaml] fix lexing nested sequences/mappings#33763

Merged

fabpot added a commit that referenced this pull request

Nov 19, 2020

bug#33763[Yaml] fix lexing nested sequences/mappings (xabbuh)

308231a

This PR was merged into the 4.4 branch.Discussion----------[Yaml] fix lexing nested sequences/mappings| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#34805,#37788,#37876,#39011,#39013,#39064| License       | MIT| Doc PR        |Commits-------4c15f80 fix lexing nested sequences/mappings