Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add message timestamp to amqp connection#37867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Add message timestamp to amqp connection#37867
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Messenger/Bridge/Amqp/Tests/Transport/ConnectionTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
f4be339 to53cb6a8Compare| $amqpExchange->expects($this->once())->method('declareExchange'); | ||
| $amqpExchange->expects($this->once())->method('publish')->with('body',null,AMQP_NOPARAM, ['headers' => [],'delivery_mode' =>2]); | ||
| $amqpExchange->expects($this->once())->method('publish')->with('body',null,AMQP_NOPARAM, ['headers' => [],'delivery_mode' =>2,'timestamp' => ClockMock::time()]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of using ClockMock directly, you should use a@group time-sensitive annotation on the test class itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah I see now, fixed :)
53cb6a8 to9c3989bCompare9c3989b to281540eComparefabpot commentedAug 18, 2020
Thank you@bzajacc. |
Add default timestamp to amqp transport message.
It is useful when you logging each message, and your consumer is down, you alway get right message time when start consume again.