Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer][ClassDiscriminatorMapping] Fix getMappedObjectType() when a discriminator child extends another one#37860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#37742
LicenseMIT
Doc PR-

The strategy is to sort the passed classes from the "bottom" one in the hierarchy to the "top" one so that the firstis_a ingetMappedObjectType() is right.

@fabpot
Copy link
Member

@fancyweb Can you check the tests?

@fancywebfancywebforce-pushed theserializer-fix-class-discriminator branch from8232835 toc16a192CompareAugust 18, 2020 07:04
@fancyweb
Copy link
ContributorAuthor

@fabpot Tests are green :-)

@fabpot
Copy link
Member

Thank you@fancyweb.

@fabpotfabpot merged commit7f7b447 intosymfony:4.4Aug 18, 2020
@fancywebfancyweb deleted the serializer-fix-class-discriminator branchAugust 18, 2020 07:35
This was referencedAug 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fancyweb@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp