Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Add missing NullToken vote#37844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesAug 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that having the BC break listed in the UPGRADE file is enough.
1dd0ca9 tof17746cCompareThank you@wouterj. |
Merged
fabpot added a commit that referenced this pull requestAug 18, 2020
This PR was squashed before being merged into the 5.2-dev branch.Discussion----------[Security] Fixed tests| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This fixes a test bug introduced by#37844 Next time, I'll open a PR in draft state before I'm sure I didn't break any tests, sorry!In order to make up for my mistake, I've also fixed another failing test introduced by#37847Commits-------c57b879 Remove MimeMessageNormalizer if the Mime component is not installed98802e5 Use PUBLIC_ACCESS from AuthenticatedVoter
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing with 5.2-dev, I discovered I forgot to add a granted vote for
PUBLIC_ACCESS.I also think it makes more sense now to move the constant from
AccessListenertoAuthenticatedVoter(to not have a dependency on Http constants in a Core voter). This is however a BC break, should we do anything more to facility our early-adapters?