Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Fix custom formats deprecation with HTML5 widgets#37837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromfancyweb:form-html5-format-deprec
Sep 24, 2020

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#37698
LicenseMIT
Doc PR-
  1. The options resolver only show the deprecations for user defined (overidden) options.
  2. The default value of thehtml5 option is enough to pass the logical condition of the callback.

That means that only setting theformat option (like in the reproducer) does not trigger the deprecation while it should. I think we need a feature in the options resolver component to handle those kind of cases 🤷‍♂️

Meanwhile, we can fix the issue by "deprecating" all the concerned options of the logical condition of the callback.

@fancyweb
Copy link
ContributorAuthor

Looking at the failing tests I just noticed I did not fix all cases yet. Before putting more efforts in, what do you think of the proposed solution@xabbuh?

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneAug 31, 2020
@nicolas-grekas
Copy link
Member

@fancyweb up to move this forward?
@xabbuh any comment?

@xabbuh
Copy link
Member

@fancyweb Isn't the test just failing because of the bug you are fixing here? I mean the test does not set thehtml5 option and thus now the deprecation is properly triggered which wasn't the case before while it should have been.

@fabpot
Copy link
Member

@fancyweb Can you have a look at the last comment?

@fancyweb
Copy link
ContributorAuthor

@xabbuh I finally took the time to look at this and you were right. I set the html5 option to false on the failing test.

xabbuh reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@fancyweb.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fancyweb@nicolas-grekas@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp