NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] Add LinkedIn provider#37830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromismail1432:notifier-add-linkedin-provider

Aug 18, 2020

Merged

[Notifier] Add LinkedIn provider#37830

fabpot merged 1 commit intosymfony:masterfromismail1432:notifier-add-linkedin-provider

Aug 18, 2020

Conversation

Copy link

Contributor

ismail1432 commentedAug 13, 2020•
edited
Loading

Q	A
Branch?	master for features 5.2
Bug fix?	no
New feature?	yes/no
Deprecations?	yes/no
Tickets	Fix#34563
License	MIT
Doc PR	symfony/symfony-docs#...

Add the LinkedIn provider for the Notifier

Few months ago I created a bridge to send message to LinkedIn, followingthe discussion here I create the PR.

If you're curiousI wrote an article where I use the bridge

[Edit] test are green~~missing improvement body construction and integration test with update changes + framework integration~~

Notification sent with this PR

carsonbot added Status: Needs Review Notifier Feature Deprecation labels

Aug 13, 2020

YaFou suggested changes

Aug 13, 2020

View reviewed changes

Copy link

Contributor

YaFou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small review ;)

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransport.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 13, 2020

SHTIKOV reviewed

Aug 14, 2020

View reviewed changes

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInOptions.phpShow resolvedHide resolved

SHTIKOV reviewed

Aug 14, 2020

View reviewed changes

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransport.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransport.phpShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransportFactory.phpShow resolvedHide resolved

ismail1432 force-pushed thenotifier-add-linkedin-provider branch 2 times, most recently fromaf79138 toe5dfb1dCompare

August 15, 2020 08:50

ismail1432 changed the title~~[Notifier] WIP Add linkedin provider~~[Notifier] Add LinkedIn provider

Aug 16, 2020

HaiYassin reviewed

Aug 17, 2020

View reviewed changes

Copy link

HaiYassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

GG for this working

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransport.phpShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/LinkedIn/Tests/LinkedInTransportTest.phpShow resolvedHide resolved

Copy link

ContributorAuthor

ismail1432 commentedAug 18, 2020

failing test seems not related 🤔

fabpot requested changes

Aug 18, 2020

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor style changes needed.

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInOptions.php Outdated

		public static function fromNotification(Notification $notification): self
		{
		$options = new self();
		$options->specificContent((new ShareContentShare($notification->getSubject())));

Copy link

Member

fabpotAug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

extra() can be removed (same 3 more times below)

Copy link

ContributorAuthor

ismail1432Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransportFactory.php Outdated

		return (new LinkedInTransport($authToken, $accountId, $this->client, $this->dispatcher))
		->setHost($host)
		->setPort($port)
		;

Copy link

Member

fabpotAug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can be on one line

Copy link

ContributorAuthor

ismail1432Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

src/Symfony/Component/Notifier/Bridge/LinkedIn/README.md Outdated

		@@ -0,0 +1,20 @@
		LinkedIn Notifier
		====================

Copy link

Member

fabpotAug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

extra=

Copy link

ContributorAuthor

ismail1432Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

src/Symfony/Component/Notifier/Bridge/LinkedIn/Share/ShareMediaShare.php Outdated

		bool $landingPage = false,
		string $landingPageTitle = null,
		string $landingPageUrl = null
		) {

Copy link

Member

fabpotAug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be on one line

Copy link

ContributorAuthor

ismail1432Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed

add Linkedin transport and option

0064cae

ismail1432 force-pushed thenotifier-add-linkedin-provider branch from011d958 to0064caeCompare

August 18, 2020 08:43

ismail1432 requested a review fromfabpot

August 18, 2020 09:01

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Aug 18, 2020

fabpot approved these changes

Aug 18, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 18, 2020

Copy link

Member

fabpot commentedAug 18, 2020

@ismail1432 Can you submit a PR on symfony/recipes?

Copy link

Member

fabpot commentedAug 18, 2020

Thank you@ismail1432.

fabpot merged commit14c9d05 intosymfony:master

Aug 18, 2020

fabpot mentioned this pull request

Aug 18, 2020

[Notifier] Add LinkedIn providersymfony/symfony-docs#14099

Closed

fabpot mentioned this pull request

Oct 5, 2020

Release v5.2.0-BETA1#38417

Merged

Labels

Deprecation Feature Notifier Status: Reviewed

Movatterモバイル変換

Uh oh!

[Notifier] Add LinkedIn provider#37830

[Notifier] Add LinkedIn provider#37830

Uh oh!

Conversation

ismail1432 commentedAug 13, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Add the LinkedIn provider for the Notifier

Uh oh!

YaFou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HaiYassin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ismail1432 commentedAug 18, 2020

Uh oh!

fabpot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabpot commentedAug 18, 2020

Uh oh!

fabpot commentedAug 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ismail1432 commentedAug 13, 2020•
edited
Loading