Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix BC layer for stamps moved into separate packages#37826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ogizanagi commentedAug 13, 2020
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#37616 |
| License | MIT |
| Doc PR | N/A |
| self::assertSame([ | ||
| DoctrineReceivedStamp::class => [$s1,$s3], | ||
| RedisReceivedStamp::class => [$s2], | ||
| ],$envelope->all()); |
ogizanagiAug 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unfortunately, I think we cannot do much for the case someone callsEnvelope::all() with no type argument and still uses the alias instead of the new fqcn to do their things.
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedAug 17, 2020
Thank you@ogizanagi. |