Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix redis connect with empty password#37791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexander-schranz
Copy link
Contributor

@alexander-schranzalexander-schranz commentedAug 10, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix -
LicenseMIT
Doc PRsymfony/symfony-docs#...

If you use DSN like this it will fail as auth is called with an empty password:

redis://%env(resolve:REDIS_PASSWORD)%@%env(resolve:REDIS_HOST)%

The auth should only be called when a password is set to a specific string.

Else it will fail with:

ERR Client sent AUTH, but no password is set

Redis Conf "redis-nopass.conf":

requirepass""

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With minor comment

@alexander-schranzalexander-schranz changed the titleAvoid redis auth call for empty passwordFix redis connect with empty passwordAug 10, 2020
@alexander-schranzalexander-schranzforce-pushed thebugfix/redis-empty-password branch 3 times, most recently from9a8b439 toe8bcf5fCompareAugust 10, 2020 12:52
@fabpotfabpotforce-pushed thebugfix/redis-empty-password branch fromf7648c0 to9946f7fCompareAugust 10, 2020 13:30
@fabpot
Copy link
Member

Thank you@alexander-schranz.

@fabpotfabpot merged commitb2e99e2 intosymfony:4.4Aug 10, 2020
@alexander-schranzalexander-schranz deleted the bugfix/redis-empty-password branchAugust 10, 2020 13:41
This was referencedAug 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexander-schranz@fabpot@ro0NL@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp