Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] trans, add support of domain in $id message#37769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
YaFou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 Can you add a test for this feature?
wtorsi commentedAug 8, 2020
@YaFou sure, done |
# Conflicts:#src/Symfony/Component/Translation/Translator.php
YaFou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good job@wtorsi! And great feature!
xabbuh commentedAug 8, 2020
This looks like a BC break to me as it will break most existing translations that contain the |
YaFou commentedAug 8, 2020
Good point. A solution may be to add an argument to the |
wtorsi commentedAug 8, 2020
Just found that |
ro0NL commentedAug 9, 2020
Shouldnt we prefer the approach in#37670? |
wtorsi commentedAug 9, 2020
I prefer the approach of translatable objects in#37670 , but my idea is to encode domain in message ID itself, because in my opinion it is easier to store such ids in database |
fabpot commentedAug 11, 2020
I'm against this change. First, it's a BC break, then, it looks a bit hacky, it's also yet another way to do something we can already do, and last, it does not work well when you are not using translation strings: Thanks for proposing. |
Add support of domain in id message while translating