Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix deprecated libxml_disable_entity_loader#37763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $valid = @$dom->schemaValidateSource($source); | ||
| libxml_disable_entity_loader($disableEntities); | ||
| }else { | ||
| $valid = @$dom->schemaValidateSource($source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure about this change: in previous code, the entity_loader were enabled, but the flagLIBXML_NOENT is not supported byschemaValidateSource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
derrabus commentedAug 8, 2020
This should be fixed on 3.4. |
jderusse commentedAug 9, 2020
good catch@derrabus . Rebased. |
fabpot commentedAug 10, 2020
Thank you@jderusse. |
Uh oh!
There was an error while loading.Please reload this page.
Fix deprecation
Function libxml_disable_entity_loader() is deprecatedtriggered byphp/php-src#5867 in PHP8