Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] Fix for #36624; Allow PHP constant as first key in block#37744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromjnye:issue-36624
Aug 11, 2020
Merged

[Yaml] Fix for #36624; Allow PHP constant as first key in block#37744

fabpot merged 1 commit intosymfony:3.4fromjnye:issue-36624
Aug 11, 2020

Conversation

@jnye
Copy link
Contributor

@jnyejnye commentedAug 5, 2020

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36624
LicenseMIT
Doc PR

When using a PHP constant in the first key of a mapping the parser would throw an exception. However if you used a PHP constant in any other key but the first it was allowed. This fix allows PHP constant as the first key.

I've included a test for this parser error along with the fix.

andrew-demb reacted with thumbs up emoji
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we could expand the test to check for more tags using a data provider.

@fabpot
Copy link
Member

Thank you@jnye.

@fabpotfabpot merged commita77901d intosymfony:3.4Aug 11, 2020
This was referencedAug 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jnye@fabpot@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp