Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] do not use deprecated mailer.logger_message_listener service#37728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedAug 3, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
| $container->getDefinition('mailer.transports')->setArgument(0,$transports); | ||
| $container->getDefinition('mailer.default_transport')->setArgument(0,current($transports)); | ||
| $container->removeDefinition('mailer.logger_message_listener'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why removing a definition and adding a deprecated alias following it ? Why not creating the right deprecated alias from the beginning ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Themailer.message_logger_listener service is not always defined (only when the profiler is enabled).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but here, you still remove themailer.logger_message_listener definition all the time to replace it by an alias. So I don't see how this matters.
fabpot commentedAug 11, 2020
Thank you@xabbuh. |
…logger listener (xabbuh)This PR was merged into the 5.2-dev branch.Discussion----------[FrameworkBundle] properly choose the best mailer message logger listener| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Properly merge the changes from#37729 and#37728.Commits-------6cffc79 properly choose the best mailer message logger listener