Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Fix Guess phpdoc return type#37725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
yceruto approved these changesAug 3, 2020
Uh oh!
There was an error while loading.Please reload this page.
ogizanagi approved these changesAug 13, 2020
fabpot approved these changesAug 13, 2020
Member
fabpot commentedAug 13, 2020
Thank you@franmomu. |
This was referencedAug 31, 2020
Merged
Merged
Merged
franmomu added a commit to franmomu/SonataAdminBundle that referenced this pull requestAug 31, 2020
symfony/symfony#37725 was released in 4.4.12
franmomu added a commit to franmomu/SonataAdminBundle that referenced this pull requestAug 31, 2020
symfony/symfony#37725 was released in 4.4.12
OskarStark pushed a commit to sonata-project/SonataAdminBundle that referenced this pull requestSep 1, 2020
symfony/symfony#37725 was released in 4.4.12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
Guessis abstract,staticrepresents better the return type, so callingTypeGuess::getBestGuess()would returnTypeGuessinstead ofGuess.