Jul 31, 2020 · Jul 31, 2020 · Aug 3, 2020 · Aug 6, 2020 · Oct 5, 2020 · Oct 5, 2020
diff --git a/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
     *   * queues[name]: An array of queues, keyed by the name
     *     * binding_keys: The binding keys (if any) to bind to this queue
     *     * binding_arguments: Arguments to be used while binding the queue.
     *     * bindings[name]: An array of bindings for this queue, keyed by the name
     *       * key: The binding key (if any) to bind to this queue
     *       * arguments: An array of arguments to be used while binding the queue.
     *     * flags: Queue flags (Default: AMQP_DURABLE)
     *     * arguments: Extra arguments
     *   * exchange:

        foreach ($this->queuesOptions as $queueName => $queueConfig) {
            $this->queue($queueName)->declareQueue();
            foreach ($queueConfig['bindings'] ?? [] as $binding) {
                $this->queue($queueName)->bind($this->exchangeOptions['name'], $binding['key'] ?? null, $binding['arguments'] ?? []);
            }
            if (isset($queueConfig['bindings']) && empty($queueConfig['binding_keys'])) {
                continue;
            }
            foreach ($queueConfig['binding_keys'] ?? [null] as $bindingKey) {
                $this->queue($queueName)->bind($this->exchangeOptions['name'], $bindingKey, $queueConfig['binding_arguments'] ?? []);
            }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -131,6 +131,9 @@ public function __construct(array $connectionOptions, array $exchangeOptions, ar
		* * queues[name]: An array of queues, keyed by the name
		* * binding_keys: The binding keys (if any) to bind to this queue
		* * binding_arguments: Arguments to be used while binding the queue.
		* * bindings[name]: An array of bindings for this queue, keyed by the name
		* * key: The binding key (if any) to bind to this queue
		* * arguments: An array of arguments to be used while binding the queue.
		* * flags: Queue flags (Default: AMQP_DURABLE)
		* * arguments: Extra arguments
		* * exchange:
Expand DownExpand Up		@@ -443,6 +446,12 @@ private function setupExchangeAndQueues(): void

		foreach ($this->queuesOptions as $queueName => $queueConfig) {
		$this->queue($queueName)->declareQueue();
		foreach ($queueConfig['bindings'] ?? [] as $binding) {
Copy link Member weaverryanOct 1, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. In the example in the PR description, you show using an array key under`bindings` - like`manual-messages`, but that is not used here. What is the purpose of this YAML key? You also show an example without one. Which is the correct usage? Copy link Author inferontOct 1, 2020• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I am not sure there is or should be a correct usage. The original intent was that these bindings could have a developer/human friendly name. I have found that using these names for the bindings is useful when we have more than a dozen bindings. In my projects, all of these bindings would ideally have a name. I do not think I would want to force another developer to do this generally though. I'm okay with any suggestions here though.
		$this->queue($queueName)->bind($this->exchangeOptions['name'], $binding['key'] ?? null, $binding['arguments'] ?? []);
		}
		if (isset($queueConfig['bindings']) && empty($queueConfig['binding_keys'])) {
Copy link Member weaverryanOct 1, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think this isn't needed? Because if`$queueConfig['binding_keys'])` is empty, then the next foreach wouldn't do anything anyways. Copy link Author inferontOct 2, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. The '?? [null]' in the next line will ensure that bind is called at least once with a null $bindingKey if 'binding_keys' is empty. This would have the effect of binding all messages from the exchange to the queue.
		continue;
		}
		foreach ($queueConfig['binding_keys'] ?? [null] as $bindingKey) {
		$this->queue($queueName)->bind($this->exchangeOptions['name'], $bindingKey, $queueConfig['binding_arguments'] ?? []);
		}
Expand Down