Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Debug validator command#37706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@loic425
Copy link
Contributor

@loic425loic425 commentedJul 29, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#...

help

CustomerAddress

Customer

Shine-neko, rupa4ok, ogizanagi, YaFou, Kocal, and lchrusciel reacted with heart emoji
@loic425loic425force-pushed thefeature/debug-validator-command branch 4 times, most recently from9687b0e tof281244CompareJuly 30, 2020 07:43
@nicolas-grekasnicolas-grekas added this to thenext milestoneJul 30, 2020
Copy link
Contributor

@noniagriconomienoniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice add :)
small review passing by

@loic425loic425force-pushed thefeature/debug-validator-command branch 2 times, most recently from630ac4f to5a5236eCompareJuly 31, 2020 15:10
Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for working on this, I think it's a really nice addition ✨

@loic425loic425force-pushed thefeature/debug-validator-command branch from07522f9 to8581aa2CompareAugust 26, 2020 13:12
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to fix tests with low deps. In the FrameworkBundle composer.json file, you need to require symfony/validator ^5.2.

}
}

if (empty($rows)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if (!$rows) {

@loic425
Copy link
ContributorAuthor

You need to fix tests with low deps. In the FrameworkBundle composer.json file, you need to require symfony/validator ^5.2.

@fabpot It seems to be not enough.
https://travis-ci.org/github/symfony/symfony/jobs/724055904#L6907

@fabpotfabpotforce-pushed thefeature/debug-validator-command branch 2 times, most recently from42e2753 to5847037CompareSeptember 5, 2020 14:25
@fabpotfabpotforce-pushed thefeature/debug-validator-command branch from5847037 to6ec54c7CompareSeptember 5, 2020 14:41
@fabpot
Copy link
Member

Thank you@loic425.

loic425 reacted with thumbs up emojiloic425 reacted with hooray emoji

@fabpotfabpot merged commit4ab612c intosymfony:masterSep 5, 2020
@loic425loic425 deleted the feature/debug-validator-command branchSeptember 5, 2020 16:38
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

+2 more reviewers

@ogizanagiogizanagiogizanagi left review comments

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

6 participants

@loic425@fabpot@ogizanagi@noniagriconomie@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp