Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Added the missing reset tag to mailer.logger_message_listener#37705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@vudaltsov
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT
Doc PR

@fabpot
Copy link
Member

Thank you@vudaltsov.

@fabpotfabpot merged commite69b8b1 intosymfony:4.4Jul 30, 2020
@vudaltsovvudaltsov deleted the mailer-logger-message-listener-reset-tag branchJuly 30, 2020 11:41
fabpot added a commit that referenced this pull requestAug 2, 2020
… env=prod (vudaltsov)This PR was squashed before being merged into the 5.2-dev branch.Discussion----------[Mailer] Prevent MessageLoggerListener from leaking in env=prod| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| License       | MITI was trying to send a batch of emails with `--env=prod` when I noticed that `MessageLoggerListener` was still collecting all the messages and leaking the memory. I tried to do `$this->getApplication()->reset()`, but it didn't work because `MessageLoggerListener` was not tagged (now fixed in#37705).In this PR I propose to move the declaration of `MessageLoggerListener` to `mailer_debug.php` since the only service depending on it is `mailer.data_collector` from `mailer_debug.php`. If a developer needs to collect sent emails, a custom listener could be implemented on the project side.- [x] deprecate the service- [x] add a new one to `mailer_debug.php`- [ ] add a line to CHANGELOG.md- [ ] add a line to UPGRADE-5.2.mdCommits-------e226775 [Mailer] Prevent MessageLoggerListener from leaking in env=prod
This was referencedAug 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vudaltsov@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp