Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Added the missing reset tag to mailer.logger_message_listener#37705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:4.4fromvudaltsov:mailer-logger-message-listener-reset-tagJul 30, 2020
Merged
[Mailer] Added the missing reset tag to mailer.logger_message_listener#37705
fabpot merged 1 commit intosymfony:4.4fromvudaltsov:mailer-logger-message-listener-reset-tagJul 30, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
vudaltsov commentedJul 29, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | no |
| License | MIT |
| Doc PR |
fabpot approved these changesJul 30, 2020
Member
fabpot commentedJul 30, 2020
Thank you@vudaltsov. |
4 tasks
fabpot added a commit that referenced this pull requestAug 2, 2020
… env=prod (vudaltsov)This PR was squashed before being merged into the 5.2-dev branch.Discussion----------[Mailer] Prevent MessageLoggerListener from leaking in env=prod| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | yes| License | MITI was trying to send a batch of emails with `--env=prod` when I noticed that `MessageLoggerListener` was still collecting all the messages and leaking the memory. I tried to do `$this->getApplication()->reset()`, but it didn't work because `MessageLoggerListener` was not tagged (now fixed in#37705).In this PR I propose to move the declaration of `MessageLoggerListener` to `mailer_debug.php` since the only service depending on it is `mailer.data_collector` from `mailer_debug.php`. If a developer needs to collect sent emails, a custom listener could be implemented on the project side.- [x] deprecate the service- [x] add a new one to `mailer_debug.php`- [ ] add a line to CHANGELOG.md- [ ] add a line to UPGRADE-5.2.mdCommits-------e226775 [Mailer] Prevent MessageLoggerListener from leaking in env=prod
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.