Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] fix saving no-expiry items with ArrayAdapter#37671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromphilipp-kolesnikov:ticket_37667
Jul 31, 2020

Conversation

@philipp-kolesnikov
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#37667
LicenseMIT
Doc PR

0 is a special value that means "infinity".

alongosz and andrerom reacted with thumbs up emoji
@alongosz
Copy link

Hi. Our product - eZ Platform -is affected by that as well.
I've checked this fix with our CI and can confirm it solves the issue. Thanks :)

xabbuh reacted with thumbs up emoji

@xabbuhxabbuh added this to the3.4 milestoneJul 27, 2020
@nicolas-grekasnicolas-grekas changed the titleFixes #37667[Cache] fix saving no-expiry items with ArrayAdapterJul 29, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix.
Would it be possible to add another test case inAdapterTestCase that hit the bug without usingTagAwareAdapter?

@fabpot
Copy link
Member

Thank you@philipp-kolesnikov.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@philipp-kolesnikov@alongosz@fabpot@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp