Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix invalid option sslmode in AmazonSqs bridge#37654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cea413e tofa8672bCompare| } | ||
| // check for extra keys in options | ||
| $optionsExtraKeys =array_diff(array_keys($options),array_keys(self::DEFAULT_OPTIONS)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
moved the checks before the merge of$options = $query + $options to distinguish errors inoption anddsn.
maybe it doesn't worth it, and we should just keep the first check onoptions
Uh oh!
There was an error while loading.Please reload this page.
migo315 commentedJul 29, 2020
Tested your changes locally (have same problem) and worked for me 👍 |
fabpot commentedJul 31, 2020
Thank you@jderusse. |
The sslmode option allows people to use AmazonSqs with non-offical endpoint like theasyncaws/testing-sqs docker image
By fixing precedence of DNS options in#37269 I introduced a bug that trigger an exception
Unknown option found: [sslmode]. I apologize for thisThis PR adds
sslmodein list of allowed options