Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Connect to RedisCluster with password auth#37624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frommforbak:patch-1
Jul 23, 2020

Conversation

@mforbak
Copy link
Contributor

@mforbakmforbak commentedJul 21, 2020
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Currently it is not possible to connect to RedisCluster with password. AUTH param is described in documentation (last example)https://symfony.com/doc/current/components/cache/adapters/redis_adapter.html#configure-the-connection but totally ignored in the code and connection fails

RedisAdapter::createConnection(    'redis:?host[localhost]&host[localhost:6379]&host[/var/run/redis.sock:]&auth=my-password&redis_cluster=1');

See RedisCluster usage herehttps://github.com/phpredis/phpredis/blob/develop/cluster.markdown#declaring-a-cluster-with-an-array-of-seeds

andreyserdjuk reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas changed the titleConnect to RedisCluster with password auth[Cache] Connect to RedisCluster with password authJul 22, 2020
@nicolas-grekas
Copy link
Member

Can you please rebase+target branch 4.4, and also fill in the PR template properly in the description?

@mforbakmforbak changed the base branch frommaster to4.4July 22, 2020 12:47
@mforbakmforbak changed the base branch from4.4 tomasterJuly 22, 2020 12:49
Currently it is not possible to connect to RedisCluster with password. AUTH param is described in documentation (last example)https://symfony.com/doc/current/components/cache/adapters/redis_adapter.html#configure-the-connection but totally ignored in the code and connection fails```RedisAdapter::createConnection(    'redis:?host[localhost]&host[localhost:6379]&host[/var/run/redis.sock:]&auth=my-password&redis_cluster=1');```See RedisCluster usage herehttps://github.com/phpredis/phpredis/blob/develop/cluster.markdown#declaring-a-cluster-with-an-array-of-seeds
@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.4July 23, 2020 09:54
@nicolas-grekas
Copy link
Member

Thank you@mforbak.

mforbak reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitebc7f4b intosymfony:4.4Jul 23, 2020
This was referencedJul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mforbak@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp