Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix checks for phpunit releases on Composer 2#37607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@colinodell
Copy link
Contributor

@colinodellcolinodell commentedJul 19, 2020•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#37601
LicenseMIT
Doc PRn/a

simple-phpunit has a core assumption that any version of PHPUnit without a stable release will only have one dev version returned by Composer. Per#37601, it's possible for Composer 2 to listmore than one dev version. This breaks that assumption and therefore prevents the installation of 9.3.* (which is needed for testing on PHP 8).

The fix implemented here is to remove any versions containingdev- or-dev from the list of possible versions to see if any stable versions remain.

@GrahamCampbell
Copy link
Contributor

Related:composer/composer#9054.

@colinodellcolinodell changed the titleFix checks for phpunit releases on Composer 2 (resolves #37601)Fix checks for phpunit releases on Composer 2Jul 19, 2020
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneJul 22, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks, just some minor questions and good to go on my side

@colinodellcolinodellforce-pushed thefix-phpunit-bridge-composer-2 branch fromf64114e to2bb3f08CompareJuly 22, 2020 22:00
@fabpot
Copy link
Member

Thank you@colinodell.

@fabpotfabpot merged commit0eafc01 intosymfony:3.4Jul 23, 2020
nicolas-grekas added a commit that referenced this pull requestJul 23, 2020
This PR was squashed before being merged into the 4.4 branch.Discussion----------Require PHPUnit 9.3 on PHP 8| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| License       | MITThe first version of PHPUnit to support PHP 8.0 is PHPUnit 9.3.---Depends on#37607. Related tocomposer/composer#9054.Commits-------54b13c0 Require PHPUnit 9.3 on PHP 8
@colinodellcolinodell deleted the fix-phpunit-bridge-composer-2 branchJuly 23, 2020 13:50
This was referencedJul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@GrahamCampbellGrahamCampbellGrahamCampbell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@colinodell@GrahamCampbell@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp