Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mime] Fix EmailHeaderSame to make use of decoded value#37583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromevertharmeling:patch-1
Jul 23, 2020

Conversation

@evertharmeling
Copy link
Contributor

Fixes#35062

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#35062
LicenseMIT

fruitwasp reacted with rocket emoji
@evertharmeling
Copy link
ContributorAuthor

Do I need to take a look at the failed test?

Looks like the hinted\Symfony\Component\Mime\Header\HeaderInterface (in\Symfony\Component\Mime\Header\Headers) does not have thegetValue function.

But in the implementation the$header will be of type\Symfony\Component\Mime\Header\UnstructuredHeader which does...

@nicolas-grekasnicolas-grekas added this to the4.4 milestoneJul 22, 2020
@nicolas-grekasnicolas-grekas changed the titleFix EmailHeaderSame to make use of decoded value[Mime] Fix EmailHeaderSame to make use of decoded valueJul 22, 2020
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJul 22, 2020•
edited
Loading

Yes please, tests should be green (at least the ones related to this change)

@evertharmelingevertharmelingforce-pushed thepatch-1 branch 3 times, most recently fromcd73f52 toa26ee94CompareJuly 22, 2020 12:09
@evertharmeling
Copy link
ContributorAuthor

Test fixed, current fails are not PR related (Redis related)

@nicolas-grekas
Copy link
Member

Thank you@evertharmeling.

@nicolas-grekasnicolas-grekas merged commitdf1a1ff intosymfony:4.4Jul 23, 2020
This was referencedJul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@evertharmeling@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp