Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mime] Keep Sender full address when used by non-SMTP transports#37580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dmaicher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 Seems good to me. Some tests failing though
fabpot commentedJul 15, 2020
@dmaicher But tests are failing on deps=high, which is expected, right? |
dmaicher commentedJul 15, 2020
@fabpot ah of course. So they should pass once this fix has been merged up I guess? 😊 |
refs#36178
The
Envelopeis an SMTP concept. The Sender is used in theMAIL FROMSMTP command, where only an address is supported. But we are also supporting non-SMTP transports, where the Sender might also be used as theFromheader, where a full mailbox is supported.To take into account the 2 usages, this PR keeps the full mailbox in the Envelope and let the SMTP class only use the address (which was already the case anyway).