Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Removed @internal from Composite#37558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@vudaltsov
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#37348
LicenseMIT

I think that Composite should not be@internal. Even with the new@Compound constraint Composite is still useful for complex custom validators.

For example, I have @ExcelColumn(string $column, array $constraints) that checks that all cells in a column of an uploaded Excel file are valid. This cannot be expressed with@Compound.

@nicolas-grekas
Copy link
Member

/cc@ogizanagi maybe?

@ogizanagi
Copy link
Contributor

I don't have arguments against.
This comment let me think this was at least considered a valid use-case despite not being the main motivation.

What do you think@xabbuh?
At least, if we truly want it to be internal, we should remove this comment as well.

@xabbuh
Copy link
Member

works for me

Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about targeting 5.1?

@fabpotfabpot changed the base branch frommaster to5.1July 23, 2020 06:35
@fabpotfabpotforce-pushed thevalidator-composite-remove-internal branch fromf180fd3 to8958ce1CompareJuly 23, 2020 06:35
@fabpot
Copy link
Member

Thank you@vudaltsov.

vudaltsov reacted with hooray emoji

@fabpotfabpot merged commitab29e07 intosymfony:5.1Jul 23, 2020
@vudaltsovvudaltsov deleted the validator-composite-remove-internal branchJuly 23, 2020 11:09
@fabpotfabpot mentioned this pull requestJul 24, 2020
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

Composite probably should not be @internal

6 participants

@vudaltsov@nicolas-grekas@ogizanagi@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp