I'm really interested in this new feature! Thank you, it's promising! 👏 I also have another adapter that can be implemented:Crowdin.

@welcoMattic for the Transifex bridge, have you try to use%2F to escape/ for the token?

Before continuing the work on this PR, I ask myself several questions:

• Should we rename RemoteStorage to Transport? (like in Notifier, Mailer, ...)
• How many built-in SaaS client should we support for this first PR (should we release other "Transports" later in separate packages as it's done in Notifier?)
• Should we simplify the AbstractFactory part? (after all I think is very complex for no obvious reason)

I think we would need at least 2 (or 3) providers to exercise the API and be sure it's generic and powerful enough.
I like the feature and I'd love to add it to 5.2 if possible.

Thank you for the review. I'm ok to add 2 or 3 Providers (I will rename RemoteStorage for Provider).
I hope too include this feature in 5.2 release, I will do my best to work regularly on it, in order to be ready for 5.2.

@andrii-bodnar Hi, sorry but I do not understand how Crowdin API works for uploading translations. You mentioned theUpload Translations endpoint, but in the documentation, there is no mention of content uploading. How do I upload existing translations and in which format?

Hi@welcoMattic,

let's imagine you have domainadmin.en.xlf and French translations -admin.fr.xlf

Fileadmin.en.xlf is being added to the Crowdin project.

Now, if you want to uploadadmin.fr.xlf translations to Crowdin, you need to create a Storage with this file and useUpload Translations method. This method acceptsstorageId (admin.fr.xlf) andfileId (admin.en.xlf file ID)

@andrii-bodnar thank you for the quick answer. Ok, it's not very easy to understand the concepts of Storage and File, moreover with an Upload operation between them. But ok, I will try to implement this workflow in Symfony. Thanks again.

@andrii-bodnar can we discuss by email or inSymfony Slack? I still have difficulties to send existing translations to Crowdin.

@welcoMattic, sure, I'll try to join Symfony Slack.

This is a very welcome feature, thanks for the work guys !

Well, there's still a lot of work here before we get to a complete and stable functionality (especially for the Provider Crowdin), and then the functional tests are not written yet.

For Crowdin, we have been working the last few days with@andrii-bodnar in order to implement all needed API calls, and it remains thedelete method to implement, but Crowdin API does not allow fine deletion for translations keys. It's planned on their side to introduce such an endpoint very soon.

For Transifex, I need to work again the Provider, and explore the API more deeply to find the right way to do things.

For all these reasons, I think we should target a merge for 5.3, it's more reasonable than speed up work and merge an unstable feature in 5.2.

We've just moved away frommaster as the main branch to use5.x instead. Unfortunately, I cannot reopen the PR and change the target branch to5.x. Can you open a new PR referencing this one to not loose the discussion? Thank you for your understanding and for your help.