Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Implement additional mailer transport options#37432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromfritzmg:feature/more-mailer-options
Aug 27, 2020

Conversation

@fritzmg
Copy link
Contributor

@fritzmgfritzmg commentedJun 26, 2020
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#37300
LicenseMIT
Doc PRsymfony/symfony-docs#13911

This implements additional transport configuration options mentioned in#37300. It also adds acommand option to be able to define the command used by thesendmail transport.

Examples:

framework:mailer:transports:sendmail:sendmail://default?command=/usr/sbin/sendmail%%20-oi%%20-tlocal_domain:smtps://smtp.example.com?local_domain=example.orgrestart_threshold:smtps://smtp.example.com?restart_threshold=10&restart_threshold_sleep=1ping_threshold:smtps://smtp.example.com?ping_threshold=200

@fritzmg
Copy link
ContributorAuthor

Updated against current master.@fabpot I still think that this should be merged as is, otherwise there would still be no way of customising the command of thesendmail transport, regardless of what is configured in thephp.ini. This PR is independent of the (very useful) feature of#36131.

@OskarStark
Copy link
Contributor

restart_threshold_sleep is missing in the PR header + the documentation, it is only mentioned inCHANGELOG.md

@fritzmg
Copy link
ContributorAuthor

restart_threshold_sleep is missing in the PR header

Hm, what do you mean by that? It i used in the example.

It is missing from the proposed documentation, that is true.

@fabpotfabpotforce-pushed thefeature/more-mailer-options branch from0db6030 to665d1cdCompareAugust 27, 2020 14:56
@fabpot
Copy link
Member

Thank you@fritzmg.

fritzmg reacted with hooray emoji

@fabpotfabpot merged commitba98fd7 intosymfony:masterAug 27, 2020
@fritzmgfritzmg deleted the feature/more-mailer-options branchAugust 27, 2020 14:59
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
leofeyer added a commit to contao/contao that referenced this pull requestJan 7, 2021
Description-----------| Q                | A| -----------------| ---| Fixed issues     |Fixes#2164| Docs PR or issue | -This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes:* This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`.* Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`.* Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command).It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one.Commits-------5ea20a7 support native transport53836ae use class_exists3bbd552 update ContaoCoreBundleTestb084330 check for native mailer support in PluginTest too4df690a update AddNativeTransportFactoryPassTest for prefer-lowest72e72d2 Apply suggestions from code reviewCo-authored-by: Leo Feyer <github@contao.org>ad36b75 merge with mastere98b617 removed superfluous function1969b8e fix merge error9fbdaf8 CS49187f0 Merge branch 'master' into use-native-mailer
leofeyer added a commit to contao/manager-bundle that referenced this pull requestJan 7, 2021
Description-----------| Q                | A| -----------------| ---| Fixed issues     | Fixes #2164| Docs PR or issue | -This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes:* This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`.* Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`.* Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command).It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one.Commits-------5ea20a71 support native transport53836ae6 use class_exists3bbd552f update ContaoCoreBundleTestb084330c check for native mailer support in PluginTest too4df690a8 update AddNativeTransportFactoryPassTest for prefer-lowest72e72d27 Apply suggestions from code reviewCo-authored-by: Leo Feyer <github@contao.org>ad36b75c merge with mastere98b617f removed superfluous function1969b8e1 fix merge error9fbdaf8e CS49187f05 Merge branch 'master' into use-native-mailer
leofeyer added a commit to contao/core-bundle that referenced this pull requestJan 7, 2021
Description-----------| Q                | A| -----------------| ---| Fixed issues     | Fixes #2164| Docs PR or issue | -This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes:* This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`.* Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`.* Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command).It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one.Commits-------5ea20a71 support native transport53836ae6 use class_exists3bbd552f update ContaoCoreBundleTestb084330c check for native mailer support in PluginTest too4df690a8 update AddNativeTransportFactoryPassTest for prefer-lowest72e72d27 Apply suggestions from code reviewCo-authored-by: Leo Feyer <github@contao.org>ad36b75c merge with mastere98b617f removed superfluous function1969b8e1 fix merge error9fbdaf8e CS49187f05 Merge branch 'master' into use-native-mailer
AlexejKossmann pushed a commit to AlexejKossmann/contao that referenced this pull requestApr 6, 2021
…ao#2554)Description-----------| Q                | A| -----------------| ---| Fixed issues     |Fixescontao#2164| Docs PR or issue | -This PR adds support for the `native://default` mailer transport, which uses the PHP `sendmail_path` configuration. Some notes:* This feature is available in Symfony `5.2.0` and up. Since the `symfony/mailer` dependency is independent from other Symfony packages, it can be allowed to be installed, while everything else stays at Symfony `4.4.*`.* Since the actual transport factory for the native transport is however defined by the `symfony/framework-bundle`, an additional compiler pass is necessary, to add said transport factory to the container, if supported and not already present. This can be removed once the core requires at least Symfony `5.2.*`.* Changing the `symfony/mailer` dependency to include `5.2.*` also allows you to use [additional options](symfony/symfony#37432) for your transport (like a local domain for an SMTP relay or a custom sendmail command).It would be important to include this in the upcoming Contao 4.11 version, as otherwise there exists no possibility of using a custom sendmail command and thus you are stuck with the hardcoded one.Commits-------5ea20a7 support native transport53836ae use class_exists3bbd552 update ContaoCoreBundleTestb084330 check for native mailer support in PluginTest too4df690a update AddNativeTransportFactoryPassTest for prefer-lowest72e72d2 Apply suggestions from code reviewCo-authored-by: Leo Feyer <github@contao.org>ad36b75 merge with mastere98b617 removed superfluous function1969b8e fix merge error9fbdaf8 CS49187f0 Merge branch 'master' into use-native-mailer
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJul 30, 2021
This PR was squashed before being merged into the 5.2 branch.Discussion----------[Mailer] Document new Mailer transport optionsThis documents the additional options for the Mailer component introduced insymfony/symfony#37432Commits-------f713212 [Mailer] Document new Mailer transport options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

[Mailer] Configuration of local domain not possible?

5 participants

@fritzmg@OskarStark@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp