NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mime] switching source of mime types from Apache to "MIME-db"#37422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:masterfromdesarrolla2:ticket_37412

Jul 15, 2020

Merged

[Mime] switching source of mime types from Apache to "MIME-db"#37422

nicolas-grekas merged 1 commit intosymfony:masterfromdesarrolla2:ticket_37412

Jul 15, 2020

Conversation

Copy link

Contributor

desarrolla2 commentedJun 26, 2020

Q	A
Branch?	master
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	Fix#37412
License	MIT
Doc PR	no

carsonbot added Status: Needs Review Mime labels

Jun 26, 2020

Copy link

ContributorAuthor

desarrolla2 commentedJun 26, 2020•
edited
Loading

I preferred to use the "v1.44.0" tag instead of master because they recommend it, since there may be json format changes in the future.

Maybe you prefer that I use master branch and this script fails, if format changes.

Copy link

Member

nicolas-grekasJun 26, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

related to#37389, mp3 should be first?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, it's the most common format. You can also addmp1 like definedhere (page3).

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@YaFou could you please report this tohttps://github.com/jshttp/mime-db? Maybe send them a PR also?

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I will do that this evening!

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas: seejshttp/mime-db#201.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@YaFou can you revert this change, maybe adding a comment like// mp3 should be first
same in other places where I commented about ordering?
that'd allow unlocking this PR

Copy link

Member

nicolas-grekasJun 30, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I meant@desarrolla2 sorry

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas do you want that:

a) I put the extensions in the order that you comment at MimeTypes.php
b) I update the script update_mime_types.php to force that order after download sources
c) I add comments with your suggestions at MimeTypes.php

Copy link

Member

nicolas-grekasJun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think b) would be good. Then the comments would be found in update_mime_types.php only.

nicolas-grekas reviewed

Jun 26, 2020

View reviewed changes

src/Symfony/Component/Mime/MimeTypes.php Outdated

		'text/x-lyx' => ['lyx'],
		'text/x-makefile' => ['mk','mak'],
		'text/x-markdown' => ['md','mkd','markdown'],
		'text/x-markdown' => ['mkd','md','markdown'],

Copy link

Member

nicolas-grekasJun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if the 1st is the most used, thenmd should be first?
does the order mean something in the source db?

Copy link

Member

javiereguiluzJun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For reference, the source DB uses this preference for merging the multiple sources:

// source preference (least -> most)var preference = ['nginx', 'apache', undefined, 'iana']

nicolas-grekas reviewed

Jun 26, 2020

View reviewed changes

src/Symfony/Component/Mime/MimeTypes.php Outdated

		'application/vnd.appimage' => ['appimage'],
		'application/vnd.apple.installer+xml' => ['mpkg'],
		'application/vnd.apple.keynote' => ['key'],
		'application/vnd.apple.keynote' => ['keynote','key'],

Copy link

Member

nicolas-grekasJun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

key should be first ?

Copy link

Member

nicolas-grekas commentedJun 26, 2020•
edited
Loading

Thanks for working on this.
About my comments above related to ordering, maybe we should send them to the upstream db?

stof mentioned this pull request

Jun 26, 2020

Reorder the markdown extensionsjshttp/mime-db#200

Closed

YaFou mentioned this pull request

Jun 26, 2020

Sort audio/mpeg file extensions to the most common onejshttp/mime-db#201

Closed

YaFou reviewed

Jun 26, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php OutdatedShow resolvedHide resolved

juanmrad reviewed

Jun 29, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.phpShow resolvedHide resolved

nicolas-grekas added this to thenext milestone

Jun 30, 2020

Copy link

ContributorAuthor

desarrolla2 commentedJul 3, 2020

should i rebase the commit to improve the history?

Copy link

Member

stof commentedJul 3, 2020

@desarrolla2 yes please

nicolas-grekas reviewed

Jul 4, 2020

View reviewed changes

src/Symfony/Component/Mime/MimeTypes.php Outdated

		'msg' => ['application/vnd.ms-outlook'],
		'msh' => ['model/mesh'],
		'msi' => ['application/x-msdownload','application/x-msi'],
		'msi' => ['application/octet-stream','application/x-msdownload','application/x-msi'],

Copy link

Member

nicolas-grekasJul 4, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've checked the source and I think we should always list'application/octet-stream' last.
Alternatively, we should just skip it. The reason is that we already fallback to'application/octet-stream' by default inDataPart. For sure, listing it first is going to be a regression.

Copy link

ContributorAuthor

desarrolla2Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas you prefer that:

a) I put 'application/octet-stream' last.
b) I skip 'application/octet-stream'

Copy link

Member

nicolas-grekasJul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Skipping would be best IMHO

nicolas-grekas reviewed

Jul 6, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php OutdatedShow resolvedHide resolved

Copy link

Member

fabpot commentedJul 15, 2020

@desarrolla2 I've fixed your last commit.

fabpot approved these changes

Jul 15, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 15, 2020

[Mime] switching source of mime types from Apache to "MIME-db"

ebea452

Copy link

Member

nicolas-grekas commentedJul 15, 2020

Thank you@desarrolla2.

nicolas-grekas merged commit5a61446 intosymfony:master

Jul 15, 2020

nicolas-grekas modified the milestones:next,5.2

Oct 5, 2020

Labels

Mime Status: Reviewed

8 participants

		'audio/mp3' => ['mp3','mpga'],
		'audio/mp4' => ['m4a','mp4a','f4a'],
		'audio/mpeg' => ['mp3','mpga','mp2','mp2a','m2a','m3a'],
		'audio/mpeg' => ['mpga','mp2','mp2a','mp3','m2a','m3a'],

Movatterモバイル変換

Uh oh!

[Mime] switching source of mime types from Apache to "MIME-db"#37422

[Mime] switching source of mime types from Apache to "MIME-db"#37422

Uh oh!

Conversation

desarrolla2 commentedJun 26, 2020

Uh oh!

desarrolla2 commentedJun 26, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

fabpot commentedJun 26, 2020

Uh oh!

nicolas-grekasJun 26, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekasJun 30, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commentedJun 26, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

desarrolla2 commentedJul 3, 2020

Uh oh!

stof commentedJul 3, 2020

Uh oh!

nicolas-grekasJul 4, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fabpot commentedJul 15, 2020

Uh oh!

nicolas-grekas commentedJul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

desarrolla2 commentedJun 26, 2020•
edited
Loading

nicolas-grekasJun 26, 2020•
edited
Loading

nicolas-grekasJun 30, 2020•
edited
Loading

nicolas-grekas commentedJun 26, 2020•
edited
Loading

nicolas-grekasJul 4, 2020•
edited
Loading