Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] Fix compatibility with phpunit 9.3#37418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@gennadigennadigennadi
Copy link
Contributor

@gennadigennadigennadigennadigennadigennadi commentedJun 25, 2020•
edited
Loading

QA
Branch?master for features / 4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

In PHPUnit 9.3 some Classes were moved or renamed, to make the PhpunitBridge compatible with PhpUnit 9.3 it necessary to call the new Loader instead of the Registry.

@gennadigennadigennadi
Copy link
ContributorAuthor

I am not 100% sure if adding 9_3 is right or if it would be enough to just edit CommandForV9.
I am looking forward to your feedback.

@nicolas-grekasnicolas-grekas changed the titleFix: compatibility with phpunit 9.3[PhpUnitBridge] Fix compatibility with phpunit 9.3Jun 28, 2020
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneJun 28, 2020
@nicolas-grekas
Copy link
Member

I am not 100% sure if adding 9_3 is right or if it would be enough to just edit CommandForV9.

I think editing the existing class would be good enough:
use PHPUnit\TextUI\Configuration\Configuration as LegacyConfiguration; + aclass_exists() check for the new class should be OK.

@gennadigennadigennadigennadigennadigennadiforce-pushed thefix/compatibility-with-phpunit-93 branch from3f457d5 to871c704CompareJune 28, 2020 15:08
@nicolas-grekasnicolas-grekasforce-pushed thefix/compatibility-with-phpunit-93 branch from871c704 tode71a12CompareJune 28, 2020 15:12
@nicolas-grekas
Copy link
Member

Thank you@gennadigennadigennadi.

@nicolas-grekasnicolas-grekas merged commit9709500 intosymfony:4.4Jun 28, 2020
This was referencedJul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@gennadigennadigennadi@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp