Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MimeType] Duplicated MimeType due to PHP Bug#37291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromjuanmrad:patch-1
Jun 28, 2020

Conversation

@juanmrad
Copy link
Contributor

@juanmradjuanmrad commentedJun 15, 2020•
edited by javiereguiluz
Loading

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Issue:

Currently there is a PHP bughttps://bugs.php.net/bug.php?id=77784 that is causing several MimeTypes to be given as duplicated:

application/vnd.openxmlformats-officedocument.spreadsheetml.sheetapplication/vnd.openxmlformats-officedocument.spreadsheetml.sheet

Instead of:

application/vnd.openxmlformats-officedocument.spreadsheetml.sheet

This Patch will fix the Issues by checking if a returned MimeType is duplicated and return appropriate MimeType.

This patch should be reverted if the PHP Bug is ever fixed.

@nicolas-grekas
Copy link
Member

Thank you for telling us about this.
Could you please target branch 3.4 and add a test case also?

@nicolas-grekasnicolas-grekas modified the milestones:5.1,3.4Jun 18, 2020
@fabpot
Copy link
Member

Any news? fabbot has also some fixes for you.

@juanmradjuanmrad changed the base branch from5.1 to3.4June 23, 2020 14:38
@juanmradjuanmrad changed the base branch from3.4 to5.1June 23, 2020 14:43
@juanmrad
Copy link
ContributorAuthor

@nicolas-grekas I tried changing the base, but looks like 3.4 does not have that file. I'll be creating some test cases today and apply patches from fabbot as mentioned by@fabpot

@juanmrad
Copy link
ContributorAuthor

NVM realized it is just on another place. I'll be doing the change in a bit.

@juanmradjuanmrad changed the base branch from5.1 to3.4June 23, 2020 16:05
@juanmradjuanmrad reopened thisJun 23, 2020
@juanmradjuanmradforce-pushed thepatch-1 branch 2 times, most recently froma83d5f8 tod9d155fCompareJune 23, 2020 17:15
@juanmrad
Copy link
ContributorAuthor

@nicolas-grekas I have encountered 2 issues with my PR and would like to ask for suggestions.
on PHP 5.6 there is an issue that docx and xml files are actually reported as application/zip as they are not being recognized.
And looks like TravisCi is not running php 7.4 where this issue is present.

@nicolas-grekas
Copy link
Member

I'd suggest skipping the test on PHP5 by adding an `@requires PHP 7 annotation on the test case.
PHP 7.4 runs on the deps=low job.

@juanmrad
Copy link
ContributorAuthor

@nicolas-grekas Done thanks :).

@nicolas-grekas
Copy link
Member

Thank you@juanmrad.

@nicolas-grekasnicolas-grekas merged commit6ef3fee intosymfony:3.4Jun 28, 2020
@juanmradjuanmrad deleted the patch-1 branchJune 29, 2020 12:20
This was referencedJul 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@juanmrad@nicolas-grekas@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp