Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix precedence of DSN options for 4.4#37268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ]; | ||
| yield'options fromoptions array wins over options fromdsn' => [ | ||
| yield'options fromdsn array wins over options fromoptions' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should instead be referring to URI not DSN#36999 (comment)
especially in the context of messenger, this is not a data source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe, but this is not the purpose of this PR.
Dsn is consistent with the current code and documentation:https://symfony.com/doc/current/messenger.html#transports-async-queued-messages
Uh oh!
There was an error while loading.Please reload this page.
This PR fix précédence of DSN options over constructor options in all component on branch 4.4