Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mime] use fromString when creating a new Address#37167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromfabpot:mime-from-string-fix
Jun 9, 2020

Conversation

@fabpot
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

When creating an Address, there are two ways right now in 4.4:Address::create() which takes an email or an instance of Address andAddress::fromString() which takes an email or an email+name.

In 4.4, I propose to makecreate supports everything possible. And in 5.2, I will probably propose to deprecatefromString().

@fabpotfabpot changed the title[Mime] use fromString when creating a new Adress[Mime] use fromString when creating a new AddressJun 9, 2020
@fabpotfabpot merged commit5b719d1 intosymfony:4.4Jun 9, 2020
@fabpotfabpot deleted the mime-from-string-fix branchJune 9, 2020 15:06
fabpot added a commit that referenced this pull requestJun 9, 2020
This PR was merged into the 5.2-dev branch.Discussion----------[Mime] Deprecate Address::fromString()| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | n/a <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | n/aFollow-up of#37167Commits-------6e28fda [Mime] Deprecate Address::fromString()
@xabbuhxabbuh added this to the4.4 milestoneJun 10, 2020
This was referencedJun 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@fabpot@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp