Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] Fix ExpectDeprecationTrait::expectDeprecation() conflict#37153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?no
Tickets#37133
LicenseMIT
Doc PR-

ExpectDeprecationTrait::expectDeprecation() must be compatible with TestCase::expectDeprecation(). I'm personally against a renaming on our side because this name is the best.

phansys reacted with thumbs up emoji
@fancywebfancywebforce-pushed thephp-unit-bridge-expect-deprecation-compat branch 2 times, most recently from8911978 to6b9d6c0CompareJune 8, 2020 16:15
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks, that's the approach I was about to recommend :)

@nicolas-grekasnicolas-grekas added this to the5.1 milestoneJun 8, 2020
@fancywebfancywebforce-pushed thephp-unit-bridge-expect-deprecation-compat branch from6b9d6c0 to1e61bdeCompareJune 9, 2020 09:30
@fancywebfancywebforce-pushed thephp-unit-bridge-expect-deprecation-compat branch from1e61bde toea5bb24CompareJune 9, 2020 09:56
@fabpot
Copy link
Member

Thank you@fancyweb.

phansys reacted with hooray emoji

@fabpotfabpot merged commit5cefcc2 intosymfony:5.1Jun 10, 2020
@fancywebfancyweb deleted the php-unit-bridge-expect-deprecation-compat branchJune 10, 2020 07:03
@fabpotfabpot mentioned this pull requestJun 12, 2020
xabbuh added a commit that referenced this pull requestSep 18, 2020
…ridge (xabbuh)This PR was merged into the 5.1 branch.Discussion----------[Validator] fix lowest allowed version for the PHPUnit bridge| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |Fixes the `deps=low` build for the Validator component by only allowing versions of the PHPUnit bridge that contain#37153.Commits-------fb7ee79 fix lowest allowed version for the PHPUnit bridge
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@phansysphansysphansys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@fancyweb@fabpot@nicolas-grekas@phansys@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp