Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Add check around class_alias for generated proxy classes#37144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.1fromenumag:fix-proxies
Jun 9, 2020

Conversation

@enumag
Copy link
Contributor

QA
Branch?5.1
Bug fix?yes
New feature?no
Deprecations?nofiles -->
TicketsFix#37059
LicenseMIT
Doc PR

Here is therequested fix.

I'd like to note that I consider this kind of a workaround. I don't know why the issue only started to appear with Symfony 5.1 and not before. There might be some other problem hidden somewhere else.

lugus reacted with thumbs up emojijeremyFreeAgent reacted with heart emoji
@nicolas-grekasnicolas-grekas changed the titleAdd class_alias for generated proxy classes[DI] Add class_alias for generated proxy classesJun 8, 2020
@nicolas-grekasnicolas-grekas changed the title[DI] Add class_alias for generated proxy classes[DI] Add check around class_alias for generated proxy classesJun 8, 2020
@nicolas-grekasnicolas-grekas added this to the5.1 milestoneJun 8, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, this looks good to me.
Can you please fix tests? There is a fixture that needs an update.

@enumagenumagforce-pushed thefix-proxies branch 2 times, most recently fromc4f1a54 to990dfd5CompareJune 9, 2020 06:41
@enumag
Copy link
ContributorAuthor

@nicolas-grekas Fixed. Travis is still failing but it doesn't seem related.

@jeremyFreeAgent
Copy link
Contributor

Thanks@enumag♥️

@nicolas-grekas
Copy link
Member

Thank you@enumag.

@nicolas-grekasnicolas-grekas merged commit6d6d989 intosymfony:5.1Jun 9, 2020
@lugosium
Copy link

Thank you@enumag

1 similar comment
@CarpentierMartin
Copy link

Thank you@enumag

@PedroTroller
Copy link
Contributor

Perfect, thank you@enumag !

@fabpotfabpot mentioned this pull requestJun 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

8 participants

@enumag@jeremyFreeAgent@nicolas-grekas@lugosium@CarpentierMartin@PedroTroller@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp