Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] fix forward compatibility with Doctrine DBAL 2.11+#37141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Tobion approved these changesJun 8, 2020
fabpot approved these changesJun 8, 2020
Member
fabpot commentedJun 8, 2020
Thank you@xabbuh. |
nicolas-grekas pushed a commit that referenced this pull requestJun 9, 2020
… 2.11+ (xabbuh)This PR was merged into the 5.1 branch.Discussion----------[Messenger] fix forward compatibility with Doctrine DBAL 2.11+| Q | A| ------------- | ---| Branch? | 5.1| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |The methods will be deprecated in 2.11 (seedoctrine/dbal#4019), but the forward compatibility layer is only present in 3.0 (seedoctrine/dbal#4007).Commits-------bca4f99 fix forward compatibility with Doctrine DBAL 2.11+
nicolas-grekas added a commit that referenced this pull requestJun 9, 2020
* 4.4: minor#37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh) fix forward compatibility with Doctrine DBAL 3 [WebProfilerBundle] Set NullLogger for functional tests [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn [FrameworkBundle] Fix XSD definition Update welcome.html.php [travis] add nightly to allowed failures
nicolas-grekas added a commit that referenced this pull requestJun 9, 2020
* 5.0: minor#37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh) fix forward compatibility with Doctrine DBAL 3 [WebProfilerBundle] Set NullLogger for functional tests [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn [FrameworkBundle] Fix XSD definition Update welcome.html.php [travis] add nightly to allowed failures
nicolas-grekas added a commit that referenced this pull requestJun 9, 2020
* 5.1: minor#37141 [Messenger] fix forward compatibility with Doctrine DBAL 2.11+ (xabbuh) fix forward compatibility with Doctrine DBAL 3 [WebProfilerBundle] Set NullLogger for functional tests [Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn [FrameworkBundle] Fix XSD definition Update welcome.html.php [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait [travis] add nightly to allowed failures
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods will be deprecated in 2.11 (seedoctrine/dbal#4019), but the forward compatibility layer is only present in 3.0 (seedoctrine/dbal#4007).