Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] rework form validator tests#37104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| 'constraints' => [new NotBlank(['groups' => 'group1'])], | ||
| 'property_path' => '[foo]', | ||
| ]) | ||
| ->add('field2', null, [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While working on#37085 I realised that we couldn't add this second field and assert its constraints are not validated. Investigating the cause for it I found out that the defaultConstraintValidatorTestCase is not well suited for these kinds of tests where we cascade validation to nested fields.
2fbf8f5 tof062e08Comparexabbuh commentedJun 9, 2020
ping @symfony/mergers This is blocking#37103. :) |
yceruto commentedJun 9, 2020
This looks good to me, but Travis isn't running here, does anyone know why? |
yceruto commentedJun 9, 2020
Well, it looks like yeshttps://travis-ci.org/github/symfony/symfony/builds/696496883, but my github UI isn't displaying it 😕 |
fabpot commentedJun 9, 2020
Thank you@xabbuh. |
This PR was merged into the 3.4 branch.Discussion----------[Form] rework form validator tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |This will allow writing tests for#37103.Commits-------f062e08 rework form validator tests
Uh oh!
There was an error while loading.Please reload this page.
This will allow writing tests for#37103.