NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[PropertyAccess] Fix getter call order BC#37053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.1from1ed:fix-property-accessor-getter-order

Jun 7, 2020

Merged

[PropertyAccess] Fix getter call order BC#37053

nicolas-grekas merged 1 commit intosymfony:5.1from1ed:fix-property-accessor-getter-order

Jun 7, 2020

Conversation

Copy link

Contributor

1ed commentedJun 1, 2020•
edited
Loading

Q	A
Branch?	5.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	#37052
License	MIT
Doc PR	-

Property Accessor breaks BC due to a change in the order of calling the getters, see#37052

1ed requested a review fromdunglas as acode owner

June 1, 2020 21:32

carsonbot added Status: Needs Review PropertyAccess Bug labels

Jun 1, 2020

1ed mentioned this pull request

Jun 1, 2020

[PropertyAccess] BC break due to a modified getter calling logic#37052

Closed

dunglas approved these changes

Jun 2, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 2, 2020

Copy link

ContributorAuthor

1ed commentedJun 2, 2020•
edited
Loading

@dunglas thanks for the review. Actually I’m not 100% sure if this fix is good enough and will not break other things in Property Info. What do you think? How should I handle the breaking tests, leave as is now because it will be green after merge or I should split the PR?