Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ErrorHandler] fix setting $trace to null in FatalError#36993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:eh-trace-fix
May 28, 2020

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Spotted by@nikic inphp/php-src#5620 (comment)

@derrabus
Copy link
Member

derrabus commentedMay 28, 2020•
edited
Loading

That'll work, but since it's the second time that we have special handling for$trace === null here, I'd suggest to deal with this case at the very beginning of the method.

edit: Nevermind,$trace = null in fact does something else than$trace = [].

nicolas-grekas reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit0d2bc7b intosymfony:4.4May 28, 2020
@nicolas-grekasnicolas-grekas deleted the eh-trace-fix branchMay 28, 2020 12:24
This was referencedMay 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp