Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Change the default notify timeout value for PostgreSQL#36990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fabpot
Copy link
Member

QA
Branch?5.1
Bug fix?yes-ish
New feature?no
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

The default value of 0 means that notify is kind of disable and that incurs many SQL requests. 10 minutes is kind of arbitrary but seems to be a good balance between waiting for a message (blocking) and trying again later in case of an issue.

@fabpot
Copy link
MemberAuthor

@dunglas Does that make sense for you?

@dunglas
Copy link
Member

It shouldn't be the case because of

(microtime(true) *1000 -$this->queueEmptiedAt <$this->configuration['check_delayed_interval'])
) {
returnnull;
}

The loop should consume some CPU to allow checking for delayed updates, but shouldn't sent useless SQL queries except whencheck_delayed_interval is reached.

Maybe that the default value ofcheck_delayed_interval should be increased. But we have to find a tradeoff to support both features (delayed messages and notify). Maybe should we also make it bold in the docs thatcheck_delayed_interval should be disabled if this feature isn't used.

By the way, we should maybe callusleep() here

to save some CPU.

@fabpotfabpotforce-pushed themessenger-notify-timeout-default-value branch fromb841eab to6e5a761CompareMay 28, 2020 17:14
@fabpotfabpotforce-pushed themessenger-notify-timeout-default-value branch from6e5a761 tod9decf9CompareMay 29, 2020 03:17
@fabpotfabpot merged commit2ff26b7 intosymfony:5.1May 29, 2020
@fabpotfabpot deleted the messenger-notify-timeout-default-value branchMay 29, 2020 03:19
@fabpotfabpot mentioned this pull requestMay 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@fabpot@dunglas@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp