Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Handle fetch mode deprecation of DBAL 2.11.#36987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@derrabus
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT
Doc PRN/A

Seedoctrine/dbal#4019

DBAL has deprecated PDO-style fetch modes in favor of more explicit methods.

@derrabusderrabusforce-pushed theimprovement/3.4-fetchmode-deprecation branch 3 times, most recently fromd761aec to812f2baCompareMay 27, 2020 23:14
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneMay 28, 2020
@nicolas-grekas
Copy link
Member

There's a related failure on appveyor.

@derrabus
Copy link
MemberAuthor

There's a related failure on appveyor.

We don't haveext-pdo_sqlite on AppVeyor? 😱

@nicolas-grekas
Copy link
Member

appveyor runs without any, then with many extensions.

derrabus reacted with thumbs up emoji

@stof
Copy link
Member

add@requires extension pdo_sqlite on the test so that it is skipped in that case.

derrabus reacted with thumbs up emoji

@derrabusderrabusforce-pushed theimprovement/3.4-fetchmode-deprecation branch from812f2ba to0c1e254CompareMay 28, 2020 07:54
@derrabusderrabusforce-pushed theimprovement/3.4-fetchmode-deprecation branch from0c1e254 toed51855CompareMay 28, 2020 07:55
@derrabus
Copy link
MemberAuthor

AppVeyor is happy now. The segfaulting php 8 Cache tests on Travis is hopefully unrealated. 😅

@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commite1e314d intosymfony:3.4May 28, 2020
@derrabusderrabus deleted the improvement/3.4-fetchmode-deprecation branchMay 28, 2020 08:25
nicolas-grekas added a commit that referenced this pull requestMay 28, 2020
This PR was merged into the 4.4 branch.Discussion----------Handle fetch mode deprecation of DBAL 2.11| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AContinuation of#36987 on the 4.4 branch.Commits-------1385213 Handle fetch mode deprecation of DBAL 2.11.
This was referencedMay 31, 2020
@nicolas-grekas
Copy link
Member

Things moved in DBAL v3 and tests are now failing afterdoctrine/dbal#4049 and/ordoctrine/dbal#4045
Could you please have a look if you have some time for that?

@xabbuh
Copy link
Member

Looks like part of the fix might be as simple as backporting#37141.

derrabus reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestJun 9, 2020
…bbuh)This PR was merged into the 3.4 branch.Discussion----------[Cache] fix forward compatibility with Doctrine DBAL 3| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#36987 (comment)| License       | MIT| Doc PR        |Commits-------316efef fix forward compatibility with Doctrine DBAL 3
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@derrabus@nicolas-grekas@stof@xabbuh@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp