Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Fixed handling of CSRF logout error#36974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
chalasr merged 1 commit intosymfony:3.4fromwouterj:issue-36814/handle-logout-csrf-exceptionMay 26, 2020
Merged
[Security] Fixed handling of CSRF logout error#36974
chalasr merged 1 commit intosymfony:3.4fromwouterj:issue-36814/handle-logout-csrf-exceptionMay 26, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
27d6697 to6f61428Comparestof approved these changesMay 26, 2020
6f61428 to69be9feCompare69be9fe to50348f2Comparechalasr approved these changesMay 26, 2020
Member
chalasr commentedMay 26, 2020
Thank you@wouterj. |
This was referencedMay 31, 2020
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8 years ago, a typo was made while refactoring the
ExceptionListener, loosing this logic (46071f3). I think we should fix it.The
LogoutExceptionis a very generic name for something only used when the CSRF token is invalid. Should we match the exception message to make sure only this CSRF error is transformed into 403? I didn't yet do it because any usage ofLogoutExceptionwould have resulted in 500, which always is worse than 403.