Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix MicroKernelTrait for php 8#36943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
47b908f to5e44cb4Compare5e44cb4 to7476a16CompareUh oh!
There was an error while loading.Please reload this page.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice improvements thanks, just some nitpicking.
I've noticed that implementing an old-style configureContainer() does not raise any deprecation. Is that on purpose? I really think that we should deprecate the old way, so we can re-add the abstract methods again in Symfony 6.
Yes, that's on purpose: my opinion on this is that the is a nice extension point to easily allow extensibility of the DSL. We're fine is ppl want to use any variant of it (by taking inspiration of the one we added in 5.1).
The previous DSL is still fine, it's not deprecated and shouldn't be to me.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Tests/Kernel/MicroKernelTraitTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
7476a16 toede0502Comparederrabus commentedMay 24, 2020
Ladies and gentlemen, attached to this PR, you can witness the first green php 8 build of the 5.1 branch. 🎉 |
cdef8b7 to7f3132eComparenicolas-grekas commentedMay 24, 2020
Thank you@derrabus. |
nicolas-grekas commentedMay 24, 2020
And now master \o/ Thanks for your hard work@derrabus!!! |
This PR fixes several php 8 related issues with
MicroKernelTrait.TypeErrorsraised by php. That code broke because the wording of those errors has changed. I've replaced that logic with a hopefully less brittle reflection-based approach.I've noticed that implementing an old-style
configureContainer()does not raise any deprecation. Is that on purpose? I really think that we should deprecate the old way, so we can re-add the abstract methods again in Symfony 6.