Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Removed "services" prototype node from "custom_authenticator"#36918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedMay 23, 2020•
edited
Loading

QA
Branch?5.1
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

This was discussed multiple times in the original authenticators PR. It's a bit hacky to implement, but I think it's worth the win on DX side.

I have no idea if and how this should be documented in the CHANGELOG.

Before

security:# ...firewalls:custom_authenticator:services:                -App\Security\MyCustomAuthenticator

After

security:# ...firewalls:custom_authenticator:App\Security\MyCustomAuthenticator

Before

security:# ...firewalls:custom_authenticator:services:                -App\Security\MyCustomAuthenticator                -App\Security\OtherCustomAuthenticator

After

security:# ...firewalls:custom_authenticators:            -App\Security\MyCustomAuthenticator            -App\Security\OtherCustomAuthenticator

@wouterjwouterj changed the titleRemoved "services" prototype node from "custom_authenticator"[Security] Removed "services" prototype node from "custom_authenticator"May 23, 2020
@wouterjwouterjforce-pushed thefeature/improve-custom-authenticator-config branch 2 times, most recently fromb17c440 to8a027c2CompareMay 23, 2020 10:19
@wouterjwouterjforce-pushed thefeature/improve-custom-authenticator-config branch from8a027c2 to387ed4aCompareMay 23, 2020 10:20
@nicolas-grekasnicolas-grekas added this to the5.1 milestoneMay 23, 2020
@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commitc403789 intosymfony:5.1May 23, 2020
@wouterjwouterj deleted the feature/improve-custom-authenticator-config branchMay 23, 2020 12:29
@fabpotfabpot mentioned this pull requestMay 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wouterj@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp