Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Parse and render anonymous classes correctly on php 8#36914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#36872
LicenseMIT
Doc PRN/A

The format of the value thatget_class() returns for anonymous classes has changed in php 8. This PR attempts to detect both formats, with the help of the PHP80 polyfill where possible.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

grep 'class@' src/ -r gives a few more places, isn't it? egsrc/Symfony/Component/Messenger/Middleware/TraceableMiddleware.php

derrabus reacted with eyes emoji
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneMay 23, 2020
@derrabusderrabusforce-pushed thebugfix/render-anonymous-class branch from6669181 tod362a7cCompareMay 23, 2020 14:39
@derrabusderrabus requested a review fromsroze as acode ownerMay 23, 2020 14:39
@derrabusderrabusforce-pushed thebugfix/render-anonymous-class branch 3 times, most recently fromce625dc tof2fccb4CompareMay 23, 2020 14:53
@nicolas-grekasnicolas-grekas changed the title[Console][Debug][ErrorHandler] Render anonymous classes correctly on php 8Render anonymous classes correctly on php 8May 24, 2020
@nicolas-grekasnicolas-grekasforce-pushed thebugfix/render-anonymous-class branch fromf2fccb4 toc23c5afCompareMay 24, 2020 08:24
@nicolas-grekasnicolas-grekas changed the titleRender anonymous classes correctly on php 8Parse and render anonymous classes correctly on php 8May 24, 2020
@nicolas-grekasnicolas-grekasforce-pushed thebugfix/render-anonymous-class branch fromc23c5af to9d702fdCompareMay 24, 2020 08:35
@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit6d02565 intosymfony:4.4May 24, 2020
@derrabusderrabus deleted the bugfix/render-anonymous-class branchMay 24, 2020 08:42
This was referencedMay 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp